Checkstyle Results
The following document contains the results of Checkstyle 6.1.1 with config/sun_checks.xml ruleset. 
Info
WarningsFiles
Rules
| Category | Rule | Violations | Severity |
|---|---|---|---|
| coding | AvoidInlineConditionals | 4 |  Error |
| MagicNumber | 3 | Error | |
| design | DesignForExtension | 86 | Error |
| VisibilityModifier | 1 | Error | |
| misc | NewlineAtEndOfFile | 2 | Error |
| regexp | RegexpSingleline
|
22 | Error |
| sizes | LineLength | 43 | Error |
Details
waffle/mock/MockWindowsAccount.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 27 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 33 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 36 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 39 |
| Error |
design | DesignForExtension | Method 'getDomain' is not designed for extension - needs to be abstract, final or empty. | 76 |
| Error |
design | DesignForExtension | Method 'getFqn' is not designed for extension - needs to be abstract, final or empty. | 84 |
| Error |
design | DesignForExtension | Method 'getName' is not designed for extension - needs to be abstract, final or empty. | 92 |
| Error |
design | DesignForExtension | Method 'getSidString' is not designed for extension - needs to be abstract, final or empty. | 100 |
waffle/mock/MockWindowsAuthProvider.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
design | DesignForExtension | Method 'addGroup' is not designed for extension - needs to be abstract, final or empty. | 57 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 116). | 62 |
| Error |
design | DesignForExtension | Method 'acceptSecurityToken' is not designed for extension - needs to be abstract, final or empty. | 64 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 101). | 65 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 81). | 67 |
| Error |
design | DesignForExtension | Method 'getCurrentComputer' is not designed for extension - needs to be abstract, final or empty. | 73 |
| Error |
design | DesignForExtension | Method 'getDomains' is not designed for extension - needs to be abstract, final or empty. | 81 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 122). | 87 |
| Error |
design | DesignForExtension | Method 'logonDomainUser' is not designed for extension - needs to be abstract, final or empty. | 89 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 112). | 90 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 134). | 95 |
| Error |
design | DesignForExtension | Method 'logonDomainUserEx' is not designed for extension - needs to be abstract, final or empty. | 97 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 112). | 98 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 89). | 104 |
| Error |
design | DesignForExtension | Method 'logonUser' is not designed for extension - needs to be abstract, final or empty. | 112 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 85). | 113 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 105). | 114 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 87). | 118 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 84). | 125 |
| Error |
design | DesignForExtension | Method 'lookupAccount' is not designed for extension - needs to be abstract, final or empty. | 127 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 89). | 133 |
waffle/mock/MockWindowsIdentity.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 25 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 32 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 83). | 44 |
| Error |
design | DesignForExtension | Method 'getFqn' is not designed for extension - needs to be abstract, final or empty. | 52 |
| Error |
design | DesignForExtension | Method 'getGroups' is not designed for extension - needs to be abstract, final or empty. | 60 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 88). | 62 |
| Error |
design | DesignForExtension | Method 'getSid' is not designed for extension - needs to be abstract, final or empty. | 72 |
| Error |
design | DesignForExtension | Method 'getSidString' is not designed for extension - needs to be abstract, final or empty. | 80 |
| Error |
design | DesignForExtension | Method 'isGuest' is not designed for extension - needs to be abstract, final or empty. | 96 |
| Error |
design | DesignForExtension | Method 'impersonate' is not designed for extension - needs to be abstract, final or empty. | 104 |
waffle/mock/MockWindowsImpersonationContext.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
sizes | LineLength | Line is longer than 80 characters (found 86). | 23 |
waffle/mock/MockWindowsSecurityContext.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
design | DesignForExtension | Method 'isContinue' is not designed for extension - needs to be abstract, final or empty. | 60 |
| Error |
design | DesignForExtension | Method 'getHandle' is not designed for extension - needs to be abstract, final or empty. | 68 |
| Error |
design | DesignForExtension | Method 'getIdentity' is not designed for extension - needs to be abstract, final or empty. | 76 |
| Error |
design | DesignForExtension | Method 'getPrincipalName' is not designed for extension - needs to be abstract, final or empty. | 84 |
| Error |
design | DesignForExtension | Method 'getSecurityPackage' is not designed for extension - needs to be abstract, final or empty. | 92 |
| Error |
design | DesignForExtension | Method 'getToken' is not designed for extension - needs to be abstract, final or empty. | 100 |
| Error |
design | DesignForExtension | Method 'impersonate' is not designed for extension - needs to be abstract, final or empty. | 108 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 175). | 121 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 91). | 124 |
waffle/mock/http/SimpleFilterChain.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 25 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 32 |
| Error |
design | DesignForExtension | Method 'getRequest' is not designed for extension - needs to be abstract, final or empty. | 41 |
| Error |
design | DesignForExtension | Method 'getResponse' is not designed for extension - needs to be abstract, final or empty. | 50 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 107). | 55 |
| Error |
design | DesignForExtension | Method 'doFilter' is not designed for extension - needs to be abstract, final or empty. | 57 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 118). | 58 |
waffle/mock/http/SimpleFilterConfig.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 35 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 81). | 37 |
| Error |
design | DesignForExtension | Method 'getFilterName' is not designed for extension - needs to be abstract, final or empty. | 42 |
| Error |
design | DesignForExtension | Method 'setFilterName' is not designed for extension - needs to be abstract, final or empty. | 53 |
| Error |
design | DesignForExtension | Method 'getInitParameter' is not designed for extension - needs to be abstract, final or empty. | 60 |
| Error |
design | DesignForExtension | Method 'getInitParameterNames' is not designed for extension - needs to be abstract, final or empty. | 68 |
| Error |
design | DesignForExtension | Method 'getServletContext' is not designed for extension - needs to be abstract, final or empty. | 78 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 87). | 91 |
| Error |
design | DesignForExtension | Method 'setParameter' is not designed for extension - needs to be abstract, final or empty. | 91 |
waffle/mock/http/SimpleHttpRequest.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
misc | NewlineAtEndOfFile | File does not end with a newline. | |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 41 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 44 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 47 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 50 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 53 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 56 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 59 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 82). | 61 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 62 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 82). | 64 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 65 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 68 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 71 |
| Error |
design | DesignForExtension | Method 'addHeader' is not designed for extension - needs to be abstract, final or empty. | 107 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 84). | 112 |
| Error |
design | DesignForExtension | Method 'getHeader' is not designed for extension - needs to be abstract, final or empty. | 114 |
| Error |
design | DesignForExtension | Method 'getHeaderNames' is not designed for extension - needs to be abstract, final or empty. | 122 |
| Error |
design | DesignForExtension | Method 'getMethod' is not designed for extension - needs to be abstract, final or empty. | 130 |
| Error |
design | DesignForExtension | Method 'getContentLength' is not designed for extension - needs to be abstract, final or empty. | 138 |
| Error |
coding | AvoidInlineConditionals | Avoid inline conditionals. | 140 |
| Error |
design | DesignForExtension | Method 'getRemotePort' is not designed for extension - needs to be abstract, final or empty. | 146 |
| Error |
design | DesignForExtension | Method 'setMethod' is not designed for extension - needs to be abstract, final or empty. | 157 |
| Error |
design | DesignForExtension | Method 'setContentLength' is not designed for extension - needs to be abstract, final or empty. | 167 |
| Error |
design | DesignForExtension | Method 'setRemoteUser' is not designed for extension - needs to be abstract, final or empty. | 177 |
| Error |
design | DesignForExtension | Method 'getRemoteUser' is not designed for extension - needs to be abstract, final or empty. | 184 |
| Error |
design | DesignForExtension | Method 'getSession' is not designed for extension - needs to be abstract, final or empty. | 192 |
| Error |
design | DesignForExtension | Method 'getSession' is not designed for extension - needs to be abstract, final or empty. | 200 |
| Error |
design | DesignForExtension | Method 'getQueryString' is not designed for extension - needs to be abstract, final or empty. | 211 |
| Error |
design | DesignForExtension | Method 'setQueryString' is not designed for extension - needs to be abstract, final or empty. | 222 |
| Error |
coding | AvoidInlineConditionals | Avoid inline conditionals. | 227 |
| Error |
design | DesignForExtension | Method 'setRequestURI' is not designed for extension - needs to be abstract, final or empty. | 239 |
| Error |
design | DesignForExtension | Method 'getRequestURI' is not designed for extension - needs to be abstract, final or empty. | 246 |
| Error |
design | DesignForExtension | Method 'getParameter' is not designed for extension - needs to be abstract, final or empty. | 254 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 87). | 267 |
| Error |
design | DesignForExtension | Method 'addParameter' is not designed for extension - needs to be abstract, final or empty. | 267 |
| Error |
design | DesignForExtension | Method 'getRemoteHost' is not designed for extension - needs to be abstract, final or empty. | 274 |
| Error |
design | DesignForExtension | Method 'setRemoteHost' is not designed for extension - needs to be abstract, final or empty. | 285 |
| Error |
design | DesignForExtension | Method 'getRemoteAddr' is not designed for extension - needs to be abstract, final or empty. | 292 |
| Error |
design | DesignForExtension | Method 'setRemoteAddr' is not designed for extension - needs to be abstract, final or empty. | 303 |
| Error |
design | DesignForExtension | Method 'getUserPrincipal' is not designed for extension - needs to be abstract, final or empty. | 310 |
| Error |
design | DesignForExtension | Method 'setUserPrincipal' is not designed for extension - needs to be abstract, final or empty. | 321 |
waffle/mock/http/SimpleHttpResponse.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
misc | NewlineAtEndOfFile | File does not end with a newline. | |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 98). | 43 |
| Error |
coding | MagicNumber | '500' is a magic number. | 46 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 47 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 90). | 49 |
| Error |
design | VisibilityModifier | Variable 'bytes' must be private and have accessor methods. | 52 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 101). | 57 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 93). | 58 |
| Error |
design | DesignForExtension | Method 'getStatus' is not designed for extension - needs to be abstract, final or empty. | 77 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 103). | 82 |
| Error |
design | DesignForExtension | Method 'addHeader' is not designed for extension - needs to be abstract, final or empty. | 84 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 103). | 95 |
| Error |
design | DesignForExtension | Method 'setHeader' is not designed for extension - needs to be abstract, final or empty. | 97 |
| Error |
design | DesignForExtension | Method 'setStatus' is not designed for extension - needs to be abstract, final or empty. | 112 |
| Error |
design | DesignForExtension | Method 'getStatusString' is not designed for extension - needs to be abstract, final or empty. | 122 |
| Error |
coding | MagicNumber | '401' is a magic number. | 123 |
| Error |
design | DesignForExtension | Method 'flushBuffer' is not designed for extension - needs to be abstract, final or empty. | 132 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 103). | 134 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 144 |
| Error |
design | DesignForExtension | Method 'getHeaderNamesSize' is not designed for extension - needs to be abstract, final or empty. | 147 |
| Error |
design | DesignForExtension | Method 'getHeaderValues' is not designed for extension - needs to be abstract, final or empty. | 158 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 81). | 160 |
| Error |
coding | AvoidInlineConditionals | Avoid inline conditionals. | 160 |
| Error |
design | DesignForExtension | Method 'getHeader' is not designed for extension - needs to be abstract, final or empty. | 170 |
| Error |
coding | AvoidInlineConditionals | Avoid inline conditionals. | 172 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 90). | 176 |
| Error |
design | DesignForExtension | Method 'sendError' is not designed for extension - needs to be abstract, final or empty. | 178 |
| Error |
design | DesignForExtension | Method 'sendError' is not designed for extension - needs to be abstract, final or empty. | 186 |
| Error |
design | DesignForExtension | Method 'getWriter' is not designed for extension - needs to be abstract, final or empty. | 194 |
| Error |
design | DesignForExtension | Method 'getOutputStream' is not designed for extension - needs to be abstract, final or empty. | 202 |
| Error |
design | DesignForExtension | Method 'getOutputText' is not designed for extension - needs to be abstract, final or empty. | 212 |
waffle/mock/http/SimpleHttpSession.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
sizes | LineLength | Line is longer than 80 characters (found 81). | 33 |
| Error |
design | DesignForExtension | Method 'getAttribute' is not designed for extension - needs to be abstract, final or empty. | 38 |
| Error |
design | DesignForExtension | Method 'getAttributeNames' is not designed for extension - needs to be abstract, final or empty. | 46 |
| Error |
design | DesignForExtension | Method 'getCreationTime' is not designed for extension - needs to be abstract, final or empty. | 54 |
| Error |
design | DesignForExtension | Method 'getId' is not designed for extension - needs to be abstract, final or empty. | 62 |
| Error |
design | DesignForExtension | Method 'getLastAccessedTime' is not designed for extension - needs to be abstract, final or empty. | 70 |
| Error |
design | DesignForExtension | Method 'getMaxInactiveInterval' is not designed for extension - needs to be abstract, final or empty. | 78 |
| Error |
design | DesignForExtension | Method 'getServletContext' is not designed for extension - needs to be abstract, final or empty. | 86 |
| Error |
design | DesignForExtension | Method 'getSessionContext' is not designed for extension - needs to be abstract, final or empty. | 94 |
| Error |
design | DesignForExtension | Method 'getValue' is not designed for extension - needs to be abstract, final or empty. | 103 |
| Error |
design | DesignForExtension | Method 'getValueNames' is not designed for extension - needs to be abstract, final or empty. | 112 |
| Error |
design | DesignForExtension | Method 'isNew' is not designed for extension - needs to be abstract, final or empty. | 129 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 87). | 135 |
| Error |
design | DesignForExtension | Method 'removeAttribute' is not designed for extension - needs to be abstract, final or empty. | 146 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 91). | 161 |
| Error |
design | DesignForExtension | Method 'setAttribute' is not designed for extension - needs to be abstract, final or empty. | 163 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 87). | 164 |
waffle/mock/http/SimpleRequestDispatcher.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
sizes | LineLength | Line is longer than 80 characters (found 112). | 45 |
| Error |
design | DesignForExtension | Method 'forward' is not designed for extension - needs to be abstract, final or empty. | 47 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 110). | 48 |
| Error |
coding | MagicNumber | '304' is a magic number. | 51 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 112). | 56 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 110). | 59 |